-
Notifications
You must be signed in to change notification settings - Fork 22
2510 hi goodtimes set up cli call to processing 1 #2779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
subagonsouth
wants to merge
5
commits into
IMAP-Science-Operations-Center:dev
Choose a base branch
from
subagonsouth:2510-hi-goodtimes---set-up-cli-call-to-processing-1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+909
−28
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9350e25
Add hi goodtimes to Hi ProcessInstrument do_processing method
subagonsouth 2f4aa92
Add high level Hi goodtimes functions and test coverage
subagonsouth 541be76
Fix mocks after moving imports to global
subagonsouth 90450a7
Move loading of cdfs into cli.py for hi goodtimes
subagonsouth 40296fa
Apply suggestions from code review
subagonsouth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type annotation for Hi.do_processing should be
list[xr.Dataset | Path]instead oflist[xr.Dataset]because the goodtimes processing path returns a list of Path objects (line 858). This is consistent with the Spacecraft instrument's do_processing method which also returnslist[xr.Dataset | Path]and aligns with the post_processing method's signature which acceptslist[xr.Dataset | Path].