Skip to content

Codice l2 hi sectored dim reversal #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lacoak21 wants to merge 2 commits into
base: dev
Choose a base branch
from
+3 −1
Open

Codice l2 hi sectored dim reversal #2778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c5eb1
update the spin_angle array
lacoak21 Feb 26, 2026
36bc8e2
add comment
lacoak21 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion imap_processing/codice/codice_l2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,9 @@ def process_hi_sectored(dependencies: ProcessingInputCollection) -> xr.Dataset:
spin_angle = (L2_HI_SECTORED_ANGLE[:, np.newaxis] + elevation_angles) % 360.0
Copy link
Contributor Author

@lacoak21 lacoak21 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tech3371 Im honestly still pretty confused about this. From my understanding:
This (L2_HI_SECTORED_ANGLE[np.newaxis, :] + elevation_angles) % 360.0 already creates an array that is spin_sector by elevation angle. Unless the variable names are mismatched? I have no understanding of l2 hi sectored code so I was wondering if this change made sense to you? Michael confirmed that the transpose was needed.

Copy link
Contributor

@tech3371 tech3371 Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into the details. It's been a while for me and I can look into where we should update.


# Add spin angle variable using the new elevation_angle dimension
l2_dataset["spin_angle"] = (("spin_sector", "elevation_angle"), spin_angle)
# Spin angle needs to be transposed to have dimensions
# (spin_sector, elevation_angle) to match the L2 dataset dimensions
l2_dataset["spin_angle"] = (("spin_sector", "elevation_angle"), spin_angle.T)
l2_dataset["spin_angle"].attrs = cdf_attrs.get_variable_attributes(
"spin_angle", check_schema=False
)
Expand Down
Loading