Glows badtime flag#2760
Open
laspsandoval wants to merge 17 commits intoIMAP-Science-Operations-Center:devfrom
Open
Glows badtime flag#2760laspsandoval wants to merge 17 commits intoIMAP-Science-Operations-Center:devfrom
laspsandoval wants to merge 17 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
maxinelasp
approved these changes
Feb 25, 2026
Contributor
maxinelasp
left a comment
There was a problem hiding this comment.
This also completes ticket #2759 - nice! Looks good to me, although I'll admit I'm lost on most of the SPICE work - it might be worth getting a check from Tim on this too. Looks like the test is failing due to a type error, but once that's fixed I'm good with merging!
Contributor
subagonsouth
left a comment
There was a problem hiding this comment.
A couple of suggestions for improvement.
added 2 commits
February 25, 2026 13:29
added 2 commits
February 25, 2026 13:47
3 tasks
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new mechanism for flagging histogram bins that are close to UV sources in the GLOWS L1b data processing pipeline. The most important changes are the addition of the
flag_uv_sourcemethod, integration of this flag into the histogram flag array, and updates to testing and mock data to support and validate this feature.UV Source Masking Enhancements
flag_uv_sourcemethod toglows_l1b_data.py, which computes a boolean mask identifying bins that are within the angular radius of any UV source, using SPICE geometry and ancillary exclusions data._compute_histogram_flag_arrayto set the new UV source proximity flag in the histogram flags array, utilizing theflag_uv_sourcemethod.IS_CLOSE_TO_UV_SOURCEflag inGLOWSL1bFlagsto represent bins close to UV sources.Testing and Mock Data Improvements
mock_ancillary_exclusionsfixture to provide deterministic UV source coordinates and masking radii, ensuring reproducible test results.test_hist_spice_outputto validate the shape and count of bins flagged as close to UV sources, confirming the new masking logic works as expected. [1] [2]Imports and Code Organization
glows_l1b_data.pyto include SPICE geometry functions used for UV source masking calculations.These changes collectively improve the accuracy and reliability of UV source masking in GLOWS L1b data processing.# Change Summary
Overview
File changes
Testing