MNT: Add retry logic and better exception handling#294
Merged
greglucas merged 1 commit intoIMAP-Science-Operations-Center:mainfrom Feb 9, 2026
Merged
Conversation
lacoak21
approved these changes
Feb 9, 2026
Contributor
lacoak21
left a comment
lacoak21
left a comment
There was a problem hiding this comment.
Great fix. I have seem that
| except requests.exceptions.RequestException as e: | ||
| error_msg = f"{e.response.status_code} {e.response.reason}: {e.response.text}" | ||
| raise IMAPDataAccessError(error_msg) from e | ||
| # Handle cases where response may not exist (connection errors, timeouts, etc.) |
Contributor
There was a problem hiding this comment.
Nice - Ive definitely seen that happen before and thought it was due to something else
greglucas
merged commit 5027a6e
into
IMAP-Science-Operations-Center:main
36 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Retry logic following documentation here: https://docs.python-requests.org/en/latest/api/#requests.adapters.HTTPAdapter
There is no status code on a non-http response, so better handle that so we don't get an exception raised from within the exception.
closes #295