User: fix ids passed to filters in autocomplete (47829)#11611
Open
schmitz-ilias wants to merge 1 commit into
Open
User: fix ids passed to filters in autocomplete (47829)#11611schmitz-ilias wants to merge 1 commit into
schmitz-ilias wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the user autocomplete in EmployeeTalk, see also 47829, but the problem should apply to all usages of
ilUserAutoComplete::getListwhere a user filter is set.The underlying issue is that
array_mergere-indexes arrays with numerical keys, so when usingarray_keysto build the list of user IDs that is then passed to the filter, you always get[0, 1, 2, ...]. Usingarray_replaceinstead ofarray_mergefixes that.