Fix DST-aware UTC conversion for EXDATE and RRULE UNTIL in iCal export#11553
Open
MrKrisKrisu wants to merge 1 commit into
Open
Fix DST-aware UTC conversion for EXDATE and RRULE UNTIL in iCal export#11553MrKrisKrisu wants to merge 1 commit into
MrKrisKrisu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EXDATE and RRULE UNTIL timestamps were created by combining the target date with the UTC time of the DTSTART timestamp. When DTSTART falls in CET but the target date falls in CEST (or vice versa), the resulting UTC timestamp differs by one hour. Therefore, calendar clients that compare occurrences in UTC would not match the exception and display the excluded date anyway.
The fix involves constructing a proper datetime from the target date and the event's local start time in the user's configured time zone, and then converting to UTC.
Example:
Other Example: Series begins in DST (now)
Screenshot with both examples from Thunderbird BEFORE my change:
Screenshot with both examples from Thunderbird AFTER my change: