Skip to content

feat(IAM Identity): add support for limits/cross account#300

Open
hariarla wants to merge 1 commit intomainfrom
enable_account_limits
Open

feat(IAM Identity): add support for limits/cross account#300
hariarla wants to merge 1 commit intomainfrom
enable_account_limits

Conversation

@hariarla
Copy link
Copy Markdown
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screenshot 2026-03-31 at 12 01 47 PM Screenshot 2026-03-31 at 1 09 49 PM Screenshot 2026-03-31 at 1 10 20 PM Screenshot 2026-03-31 at 3 13 50 PM Screenshot 2026-03-31 at 3 17 03 PM Screenshot 2026-03-31 at 3 47 46 PM

Signed-off-by: Hari K Arla <hariarla@in.ibm.com>
@pyrooka pyrooka self-assigned this Mar 31, 2026
@pyrooka pyrooka self-requested a review March 31, 2026 11:35
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the files that contains only copyright year changes. The year should be updated only when there is a meaningful change in the file and it also makes the view harder as it pollutes the diff view.
I've changed my mind. Since there are a lot of files affected, I think it's fine to leave the new copyright year. It would be a lot of work to you to exclude all the aforementioned changes.

@pyrooka pyrooka self-requested a review April 1, 2026 07:12
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants