Skip to content

fix(ruleset): ignore binary responses in collection array property rule#811

Open
sjh9714 wants to merge 1 commit into
IBM:mainfrom
sjh9714:fix-binary-response-collection-array-property
Open

fix(ruleset): ignore binary responses in collection array property rule#811
sjh9714 wants to merge 1 commit into
IBM:mainfrom
sjh9714:fix-binary-response-collection-array-property

Conversation

@sjh9714
Copy link
Copy Markdown

@sjh9714 sjh9714 commented May 18, 2026

Summary

Fixes a false positive in ibm-collection-array-property for binary file responses.

What changed

  • Added regression coverage for a list... operation returning application/pdf.
  • Skipped collection array property validation for type: string, format: binary response schemas.
  • Preserved existing validation for JSON collection responses.

Why

Issue #786 reports that PDF download endpoints are flagged as missing a collection array property even though they return binary files, not collections.

Testing

  • npm run jest --workspace packages/ruleset -- test/rules/collection-array-property.test.js --runInBand
  • npm run lint --workspace packages/ruleset
  • npm run test-ruleset
  • git diff --check

Fixes #786

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 18, 2026

CLA assistant check
All committers have signed the CLA.

Signed-off-by: jinhyuk9714 <jinhyuk9714@gmail.com>
@sjh9714 sjh9714 force-pushed the fix-binary-response-collection-array-property branch from 86bede4 to 6705146 Compare May 18, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive: Rule incorrectly expects array collections property for binary PDF files

2 participants