refactor: use CloudantBaseService as a super of CloudantV1 #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricellis
reviewed
Oct 17, 2025
Member
ricellis
left a comment
ricellis
left a comment
There was a problem hiding this comment.
This looks good to me, but it does need some copyright date updates
Contributor
Author
|
@ricellis good catch, but I keep it draft, because remembered that we also want to reuse client in session auth |
eiri
force-pushed
the
1030-refactor-cloudant-base-service-class
branch
from
c0f2cac to
af755bc
Compare
eiri
force-pushed
the
1030-refactor-cloudant-base-service-class
branch
2 times, most recently
from
ad16a45 to
858f318
Compare
ricellis
reviewed
Oct 20, 2025
ricellis
approved these changes
Oct 20, 2025
Member
ricellis
left a comment
ricellis
left a comment
There was a problem hiding this comment.
1 nit I missed first time round, but +1
|
|
||
| def set_jar(self, jar): | ||
| """Sets the cookie jar for the authenticator. | ||
| def set_http_client(self, http_client: Session, jar: RequestsCookieJar) -> None: |
Member
There was a problem hiding this comment.
since it is internal can we use the leading _ naming? ofc we'd need to update the matching callers too.
Suggested change
| def set_http_client(self, http_client: Session, jar: RequestsCookieJar) -> None: | |
| def _set_http_client(self, http_client: Session, jar: RequestsCookieJar) -> None: |
eiri
force-pushed
the
1030-refactor-cloudant-base-service-class
branch
from
f7842c1 to
16867c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
CouchDbSessionAuthenticator, so it'd be used in token manager.TestPageIteratorin pagination's tests toBaseTestPageIteratorto avoid test runner's warnings.Fixes: s1030
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
We monkey-patch methods of CloudantV1 to get extended functionality for generated sdk
What is the new behavior?
Extend functionality in base class and switch CloudantV1 to inherit from it
Does this PR introduce a breaking change?
Other information