fix: disable_ssl_verification impl for CouchDbSessionAuthenticator #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricellis
approved these changes
Oct 7, 2025
eiri
force-pushed
the
s1029-fix-disable-ssl-verification
branch
from
36c2df6 to
c48f169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR removes support of
AUTH_DISABLE_SSLforCouchDbSessionAuthenticatorto keep it in line with other impl and also fixes monkey-patch forset_disable_ssl_verificationFixes: s1029
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
We treat settings for
DISABLE_SSLandAUTH_DISABLE_SSLas a separate entries in session auth, so it is possible to have it disabled for client and not for auth and visa versa. This can get confusing, since unlike other auth session queries the same URLWhat is the new behavior?
Setting for
AUTH_DISABLE_SSLdisregarded andDISABLE_SSLtreated as a main config. Same time patch toset_disable_ssl_verificationfixed, so function call works for session auth as well.Does this PR introduce a breaking change?