Skip to content

Conversation

@ricellis
Copy link
Member

PR summary

Various fixes for pagination

Fixes: s1189

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

The new pagination feature code (unreleased) from #819 had a few bugs.

  • Example code used get_next instead of has_next in if check

What is the new behavior?

  • Correct examples to use has_next

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis merged commit 72c146f into main Jul 15, 2025
10 checks passed
@ricellis ricellis deleted the s1189-pagination-example-fixes branch July 15, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants