Skip to content

Add a placeholder for TLSHandshakeBenchmark#1292

Merged
jasonkatonica merged 1 commit intoIBM:mainfrom
JinhangZhang:openjceplus/feature/TLSHandshakeBenchmark
Mar 26, 2026
Merged

Add a placeholder for TLSHandshakeBenchmark#1292
jasonkatonica merged 1 commit intoIBM:mainfrom
JinhangZhang:openjceplus/feature/TLSHandshakeBenchmark

Conversation

@JinhangZhang
Copy link
Copy Markdown
Collaborator

A placeholder for TLSHandshakeBenchmark JMH test

Signed-off-by: JinhangZhang <Jinhang.Zhang@ibm.com>
@JinhangZhang JinhangZhang force-pushed the openjceplus/feature/TLSHandshakeBenchmark branch from 6bc7db5 to cbf4dfe Compare March 24, 2026 13:49
@KostasTsiounis
Copy link
Copy Markdown
Member

I am not sure as to why we are making this change. Any insights @JinhangZhang ?

@JinhangZhang
Copy link
Copy Markdown
Collaborator Author

I am not sure as to why we are making this change. Any insights @JinhangZhang ?

I made an JMH test for PQC TLS handshake, however, I don't see it on the performance pipeline BENCHMARK section

BENCHMARK
Specify the performance benchmark you would like to run.

In this section in the performance pipeline, I can only choose an existing benchmark and run it. I can't enable the one I created I assume only the admin can do that. I thought it would be better to have one placeholder in the UI, so I can choose it and run within my repo and branch.

@jasonkatonica
Copy link
Copy Markdown
Member

I am ok pre-releasing this update before the test exists such that you can develop it more easily. We should then remove this line if we don't reach that point in time.

@KostasTsiounis
Copy link
Copy Markdown
Member

In this section in the performance pipeline, I can only choose an existing benchmark and run it. I can't enable the one I created I assume only the admin can do that. I thought it would be better to have one placeholder in the UI, so I can choose it and run within my repo and branch.

Oh, right. I see... I'm ok with it then

Copy link
Copy Markdown
Member

@KostasTsiounis KostasTsiounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@taoliult taoliult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants