Finish page allocator verification#119
Merged
wojciechozga merged 1 commit intoIBM:mainfrom Mar 26, 2026
Merged
Conversation
79969d6 to
8681f11
Compare
Signed-off-by: Lennard Gäher <l.gaeher@posteo.de>
4e67671 to
cafe775
Compare
Member
|
Thank you for this effort, it is a big milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
This finishes the page allocator verification using RefinedRust.
I made some minor changes in the implementation in the process.
In
Page::merge, I rearranged the assertion checks a bit, as this made the verification easier.In
ConfidentialMemoryAddress::add(andNonConfidentialMemoryAddress::add), I added a new check to ensure that the upper bound stays within the respective memory range. (If we don't want to actually check that at runtime, I can also remove this again and make it a precondition of the function. Then we should make those functionsunsafe, however.)This also bumps the RefinedRust version, and therefore bumps to a current nightly version of Rust.
Type of change
How to test this PR?
CI should pass.