Skip to content

Remove leaked credentials and add *.pem to .gitignore #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aram356 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove leaked credentials and add *.pem to .gitignore #285

aram356 wants to merge 1 commit into from

Conversation

@aram356
Copy link
Collaborator

@aram356 aram356 commented Feb 10, 2026 •
edited
Loading

Summary

  • Replace hardcoded Firebase API key crates/common/src/html_processor.test.html with FIREBASE_API_KEY_PLACEHOLDER
  • Add *.pem to .gitignore to prevent SSL certificates from being committed (addresses files on caching-optimizations and pbs-equativ-ssp-server-side branches)

Test plan

  • Verify html_processor tests still pass with placeholder key
  • Confirm .pem files are ignored by git after merge

Closes #283
Closes #284

@aram356 @claude
Remove leaked Firebase API key and add *.pem to .gitignore
bdcecd4 
Replace hardcoded Firebase API key in test HTML with a placeholder
and prevent SSL certificates from being committed.

Closes #283
Closes #284

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aram356 aram356 marked this pull request as draft February 10, 2026 23:46
@aram356 aram356 marked this pull request as ready for review February 10, 2026 23:46
prk-Jr
prk-Jr approved these changes Feb 11, 2026
View reviewed changes
Copy link
Collaborator

@prk-Jr prk-Jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@aram356 aram356 self-assigned this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prk-Jr prk-Jr prk-Jr approved these changes

@ChristianPavilonis ChristianPavilonis Awaiting requested review from ChristianPavilonis

Assignees

@aram356 aram356

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Firebase API key from test HTML file Remove committed SSL certificates (localhost+2.pem, localhost+2-key.pem)

2 participants

@aram356 @prk-Jr