-
Notifications
You must be signed in to change notification settings - Fork 8
Fix rust build cache github actions #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e4c644a to
a7f7d4a
Compare
a7f7d4a to
f244195
Compare
aram356
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good overall but need to retain pinned Rust version
5075497 to
12380f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we need rustup for wasm
The PR removed the manual 'rustup target add wasm32-wasip1' step but didn't replace it, causing CI to fail with missing wasm target errors. Use the action's built-in 'target' parameter instead.
aram356
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good
First run: Rust tests ~5min run
Second run: Rust tests ~1min run