Skip to content

usnat backwards compatibility for compressed padding #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chuff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

usnat backwards compatibility for compressed padding #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion iabgpp-encoder/src/main/java/com/iab/gpp/encoder/segment/UsNatCoreSegment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ protected void decodeSegment(String encodedString, EncodableBitStringFields fiel
// Necessary to maintain backwards compatibility when sensitive data processing changed from a
// length of 12 to 16 and known child sensitive data consents changed from a length of 2 to 3 in the
// DE, IA, NE, NH, NJ, TN release
if (bitString.length() == 66) {
if (bitString.length() == 60) {
bitString =
bitString.substring(0, 48) + "00000000" + bitString.substring(48, 52) + "00" + bitString.substring(52, 60) + "00";
}
else if (bitString.length() == 66) {
bitString =
bitString.substring(0, 48) + "00000000" + bitString.substring(48, 52) + "00" + bitString.substring(52, 62);
}
Expand Down
22 changes: 22 additions & 0 deletions iabgpp-encoder/src/test/java/com/iab/gpp/encoder/section/UsNatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,28 @@ public void testDecodeWithGpcSegmentExcluded() throws DecodingException {
Assertions.assertEquals(2, usNat.getMspaServiceProviderMode());
Assertions.assertEquals(false, usNat.getGpcSegmentIncluded());
}

@Test
public void testDecodeBackwardsCompatibility() throws DecodingException {
UsNat usNat = new UsNat("BVQqAAAACg");

Assertions.assertEquals(1, usNat.getSharingNotice());
Assertions.assertEquals(1, usNat.getSaleOptOutNotice());
Assertions.assertEquals(1, usNat.getSharingOptOutNotice());
Assertions.assertEquals(1, usNat.getTargetedAdvertisingOptOutNotice());
Assertions.assertEquals(0, usNat.getSensitiveDataProcessingOptOutNotice());
Assertions.assertEquals(0, usNat.getSensitiveDataLimitUseNotice());
Assertions.assertEquals(2, usNat.getSaleOptOut());
Assertions.assertEquals(2, usNat.getSharingOptOut());
Assertions.assertEquals(2, usNat.getTargetedAdvertisingOptOut());
Assertions.assertEquals(Arrays.asList(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0), usNat.getSensitiveDataProcessing());
Assertions.assertEquals(Arrays.asList(0, 0, 0), usNat.getKnownChildSensitiveDataConsents());
Assertions.assertEquals(2, usNat.getPersonalDataConsents());
Assertions.assertEquals(2, usNat.getMspaCoveredTransaction());
Assertions.assertEquals(0, usNat.getMspaOptOutOptionMode());
Assertions.assertEquals(0, usNat.getMspaServiceProviderMode());
Assertions.assertEquals(false, usNat.getGpc());
}

@Test()
public void testDecodeGarbage() {
Expand Down