TcfEuv2 decode issue #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 14, 2022 15:28
…gs that decode correctly with @iabtcf/core/TCString fail to decode using the new decoder in this repo.
Closed
added 2 commits
December 14, 2022 16:46
Collaborator
|
I checked these test cases against the latest GPP library and these tcStrings can be parsed correctly. This PR can be closed. -> @rickyblaha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the new library to decode TcfEuV2 from a GPP string, which is supposed to be backwards-compatible, but I'm getting some failures when testing with some existing TcfEuV2 strings - 2 actual ones from the wild, and one from our existing test fixtures.
This PR shows how those strings decode without issue using @iabtcf/core but all have a decode issue with this TcfEuV2 encoder.
Note I had to temporarily remove the Gvl tests from the mocha config because it had a failing test.