Skip to content

Conversation

@decodyng
Copy link
Member

This PR:

  • Creates a "nest_ingredients" parameter on Experiment object
  • Passes the list of ingredients into the Run object created within experiment
  • For runs with a FileStorageObserver attached, and with the nest_ingredients flag set to true, iterate over ingredients and add to that ingredient a FileStorageObserver with a directory at /<ingredient_name> .

@decodyng decodyng changed the title Nest Ingredients Directory Nest Ingredient Observers Inside Main Experiment Directory Aug 26, 2019
if self._id is None:
self._id = _id
if (
observer.__class__.__name__ == "FileStorageObserver"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More Pythonic: isinstance(observer, FileStorageObserver). That will also match subclasses, which is probably desirable, but if not can do observer.__class__ ==FileStorageObserver.

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants