Skip to content

Conversation

@kdw503
Copy link
Member

@kdw503 kdw503 commented Feb 11, 2025

No description provided.

function init!(algorithm::Apertures)
if algorithm.dev >= 0
cuda_init!(algorithm)
CUDA.allowscalar()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timholy ,
If CUDA.allowscalar(false) (CUDA doesn't allow scalar indexing in default), it cause 'LoadError: Scalar indexing is disallowed.' error at
(https://github.com/HolyLab/RegisterMismatch.jl/blob/8fcf86abcfaa3406bda5b9be21eaab638a6c9558/src/RegisterMismatch.jl#L290).
So, I added CUDA.allowscalar() (which is same as CUDA.allowscalar(true)) but I'm not sure this is right approach.

version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timholy, I got below error during CI workflow. So, I changed it to v4. (I think we need to change all the CI file in our repositories.)

Error: This request has been automatically failed because it uses a deprecated version of actions/cache: v1. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

@kdw503 kdw503 merged commit 2742e8f into master Feb 17, 2025
3 checks passed
@kdw503 kdw503 deleted the dwk/dev branch February 17, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants