-
Notifications
You must be signed in to change notification settings - Fork 3
small bugfixes #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small bugfixes #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR contains several small bugfixes and enhancements across multiple modules including 3D mesh rendering, numpy utilities, and vertebra constants. The changes address computation logic errors, add new parameters for enhanced functionality, and fix type annotations.
- Fixes computation bugs in surface calculation and normalization functions
- Adds new parameters for scale factor control and channel-wise dilation
- Corrects file path handling and method calls in mesh operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TPTBox/mesh3D/snapshot3D.py | Adds type annotations, scale_factor parameter, and fixes method calls with additional arguments |
| TPTBox/mesh3D/mesh.py | Fixes file extension concatenation, directory validation logic, and adds HTML export functionality |
| TPTBox/core/vert_constants.py | Adds missing has_rib attribute assignment and fixes C6 vertebra definition |
| TPTBox/core/np_utils.py | Fixes surface computation logic and adds new parameters for enhanced Gaussian smoothing |
| TPTBox/core/nii_wrapper.py | Fixes normalization calculation bug and adds new smoothing parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| C4 = 4 | ||
| C5 = 5 | ||
| C6 = 6 | ||
| C6 = 6, True, True |
Copilot
AI
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C6 vertebra definition is inconsistent with other entries. It should follow the same pattern as other vertebrae (e.g., C6 = 6 or include proper parameter names if the tuple format is intentional).
| C6 = 6, True, True | |
| C6 = 6 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into snapshot_readability
No description provided.