Skip to content

Update minimum working buffer size #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfranca0009 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update minimum working buffer size #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Iconic.Zlib.Netstandard/DeflateStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,9 @@ virtual public FlushType FlushMode
///
/// <remarks>
/// <para>
/// The working buffer is used for all stream operations. The default size is
/// 1024 bytes. The minimum size is 128 bytes. You may get better performance
/// with a larger buffer. Then again, you might not. You would have to test
/// it.
/// The working buffer is used for all stream operations. The Default size is 8192 bytes
/// on NETCF; 16384 bytes otherwise. The minimum size is 128 bytes. You may get better
/// performance with a larger buffer. Then again, you might not. You would have to test it.
/// </para>
///
/// <para>
Expand Down
7 changes: 3 additions & 4 deletions src/Iconic.Zlib.Netstandard/GZipStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,10 +560,9 @@ virtual public FlushType FlushMode
///
/// <remarks>
/// <para>
/// The working buffer is used for all stream operations. The default size is
/// 1024 bytes. The minimum size is 128 bytes. You may get better performance
/// with a larger buffer. Then again, you might not. You would have to test
/// it.
/// The working buffer is used for all stream operations. The Default size is 8192 bytes
/// on NETCF; 16384 bytes otherwise. The minimum size is 128 bytes. You may get better
/// performance with a larger buffer. Then again, you might not. You would have to test it.
/// </para>
///
/// <para>
Expand Down
4 changes: 2 additions & 2 deletions src/Iconic.Zlib.Netstandard/ZlibConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public static class ZlibConstants
public const int Z_BUF_ERROR = -5;

/// <summary>
/// The size of the working buffer used in the ZlibCodec class. Defaults to 8192 bytes.
/// The size of the working buffer used in the ZlibCodec class. Defaults to 8192 bytes on NETCF; 16384 bytes otherwise.
/// </summary>
#if NETCF
public const int WorkingBufferSizeDefault = 8192;
Expand All @@ -121,7 +121,7 @@ public static class ZlibConstants
/// <summary>
/// The minimum size of the working buffer used in the ZlibCodec class. Currently it is 128 bytes.
/// </summary>
public const int WorkingBufferSizeMin = 1024;
public const int WorkingBufferSizeMin = 128;
}

}
Expand Down
7 changes: 3 additions & 4 deletions src/Iconic.Zlib.Netstandard/ZlibStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,10 +342,9 @@ public virtual FlushType FlushMode
///
/// <remarks>
/// <para>
/// The working buffer is used for all stream operations. The default size is
/// 1024 bytes. The minimum size is 128 bytes. You may get better performance
/// with a larger buffer. Then again, you might not. You would have to test
/// it.
/// The working buffer is used for all stream operations. The Default size is 8192 bytes
/// on NETCF; 16384 bytes otherwise. The minimum size is 128 bytes. You may get better
/// performance with a larger buffer. Then again, you might not. You would have to test it.
/// </para>
///
/// <para>
Expand Down