Fix Windows Font Fallback & Add Custom Font Support#1
Open
gmalvone wants to merge 1 commit intoHe4eT:masterfrom
Open
Fix Windows Font Fallback & Add Custom Font Support#1gmalvone wants to merge 1 commit intoHe4eT:masterfrom
gmalvone wants to merge 1 commit intoHe4eT:masterfrom
Conversation
Added extension options page and configurable font settings. Fixed font fallback issue on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using the extension on Windows and noticed that the tab list page font is not loaded correctly. The issue doesn't present on Linux distros I have tested with.
The Bug:
The CSS used
font-family: sans;. On Windows,sansis not a valid keyword, causing the browser to fall back to Times New Roman (Serif). On Linuxsansis usually aliased to a recognised font, whereas this is not the case on Windows.The Fix & Feature:
var(--user-font)with a proper fallback stack (system-ui,Segoe UI,sans-serif) so it looks native on all OSs out of the box.options_ui) allowing users to define a custom font family. This is saved viabrowser.storage.sync.storageand bumped version to 1.1.2.Tested on Windows 10/11 and works perfectly. The font setting persists across browser restarts.
Extension Options Page
Custom Font Family Applied (Iosevka)
