Skip to content

Optimise new encoding functions #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobil4sk wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Optimise new encoding functions #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e121aaa
Merge encodings into a single file
tobil4sk Feb 5, 2026
93cfd0e
Avoid duplicate string iteration for ascii checks
tobil4sk Feb 5, 2026
6271fda
Add utf8 encode function that allocates output
tobil4sk Feb 5, 2026
c696b23
Pass char32_t by value instead of by reference
tobil4sk Feb 5, 2026
ecc950f
Estimate utf8 length instead of iterating
tobil4sk Feb 5, 2026
df2734c
Make Utf16::codepoint locally inline
tobil4sk Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/cpp/encoding/Utf16.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ namespace cpp
static bool isEncoded(const String& string);

static int getByteCount(const null&);
static int getByteCount(const char32_t& codepoint);
static int getByteCount(char32_t codepoint);
static int64_t getByteCount(const String& string);

static int getCharCount(const null&);
static int getCharCount(const char32_t& codepoint);
static int getCharCount(char32_t codepoint);
static int64_t getCharCount(const String& string);

static int encode(const null&, const cpp::marshal::View<uint8_t>& buffer);
static int encode(const char32_t& codepoint, const cpp::marshal::View<uint8_t>& buffer);
static int encode(char32_t codepoint, const cpp::marshal::View<uint8_t>& buffer);
static int64_t encode(const String& string, const cpp::marshal::View<uint8_t>& buffer);

static char32_t codepoint(const cpp::marshal::View<uint8_t>& buffer);
Expand Down
7 changes: 4 additions & 3 deletions include/cpp/encoding/Utf8.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,17 @@ namespace cpp
struct Utf8 final
{
static int getByteCount(const null&);
static int getByteCount(const char32_t& codepoint);
static int getByteCount(char32_t codepoint);
static int64_t getByteCount(const String& string);

static int getCharCount(const null&);
static int getCharCount(const char32_t& codepoint);
static int getCharCount(char32_t codepoint);
static int64_t getCharCount(const String& string);

static int encode(const null&, const cpp::marshal::View<uint8_t>& buffer);
static int encode(const char32_t& codepoint, const cpp::marshal::View<uint8_t>& buffer);
static int encode(char32_t codepoint, const cpp::marshal::View<uint8_t>& buffer);
static int64_t encode(const String& string, const cpp::marshal::View<uint8_t>& buffer);
static Array<uint8_t> encode(const String& string);

static char32_t codepoint(const cpp::marshal::View<uint8_t>& buffer);
static String decode(const cpp::marshal::View<uint8_t>& buffer);
Expand Down
66 changes: 0 additions & 66 deletions src/cpp/encoding/Ascii.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading