Skip to content

int64 over size_t for views #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simn merged 1 commit into from
Dec 14, 2025
Merged

int64 over size_t for views #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/cpp/marshal/Definitions.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ namespace cpp
bool operator!=(const ValueReference<T>& inRHS) const;

template<class K>
K get(int index);
K get(int64_t index);

template<class K>
void set(int index, K value);
void set(int64_t index, K value);
};

template<class T>
Expand Down Expand Up @@ -183,19 +183,19 @@ namespace cpp
TPtr operator->() const;

template<class K>
K get(int index);
K get(int64_t index);

template<class K>
void set(int index, K value);
void set(int64_t index, K value);
};

template<class T>
struct View final
{
::cpp::Pointer<T> ptr;
size_t length;
int64_t length;

View(::cpp::Pointer<T> _ptr, size_t _length);
View(::cpp::Pointer<T> _ptr, int64_t _length);

void clear();
void fill(T value);
Expand Down
4 changes: 2 additions & 2 deletions include/cpp/marshal/PointerReference.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ inline cpp::marshal::PointerReference<T>::PointerReference(const Boxed<O>& inRHS

template<class T>
template<class K>
inline K cpp::marshal::PointerReference<T>::get(int index)
inline K cpp::marshal::PointerReference<T>::get(int64_t index)
{
return (*Super::ptr)[index];
}

template<class T>
template<class K>
inline void cpp::marshal::PointerReference<T>::set(int index, K value)
inline void cpp::marshal::PointerReference<T>::set(int64_t index, K value)
{
(*Super::ptr)[index] = value;
}
Expand Down
4 changes: 2 additions & 2 deletions include/cpp/marshal/ValueReference.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ inline cpp::marshal::ValueReference<T>::ValueReference(const Boxed<O>& inRHS) :

template<class T>
template<class K>
inline K cpp::marshal::ValueReference<T>::get(int index)
inline K cpp::marshal::ValueReference<T>::get(int64_t index)
{
return (*Super::ptr)[index];
}

template<class T>
template<class K>
inline void cpp::marshal::ValueReference<T>::set(int index, K value)
inline void cpp::marshal::ValueReference<T>::set(int64_t index, K value)
{
(*Super::ptr)[index] = value;
}
Expand Down
2 changes: 1 addition & 1 deletion include/cpp/marshal/View.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include <cmath>

template<class T>
inline cpp::marshal::View<T>::View(::cpp::Pointer<T> _ptr, size_t _length) : ptr(_ptr), length(_length) {}
inline cpp::marshal::View<T>::View(::cpp::Pointer<T> _ptr, int64_t _length) : ptr(_ptr), length(_length) {}

template<class T>
inline bool cpp::marshal::View<T>::tryCopyTo(const View<T>& destination)
Expand Down