Skip to content

Commit f4a93d0

Browse files
gkastenAndroid (Google) Code Review
authored andcommitted
Merge "Use const const strings for arrays and pointers to strings"
2 parents 0d7a997 + 05d3310 commit f4a93d0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

services/audioflinger/AudioPolicyService.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343

4444
namespace android {
4545

46-
static const char *kDeadlockedString = "AudioPolicyService may be deadlocked\n";
47-
static const char *kCmdDeadlockedString = "AudioPolicyService command thread may be deadlocked\n";
46+
static const char kDeadlockedString[] = "AudioPolicyService may be deadlocked\n";
47+
static const char kCmdDeadlockedString[] = "AudioPolicyService command thread may be deadlocked\n";
4848

4949
static const int kDumpLockRetries = 50;
5050
static const int kDumpLockSleep = 20000;
@@ -1069,7 +1069,7 @@ int AudioPolicyService::setVoiceVolume(float volume, int delayMs)
10691069
// Audio pre-processing configuration
10701070
// ----------------------------------------------------------------------------
10711071

1072-
const char *AudioPolicyService::kInputSourceNames[AUDIO_SOURCE_CNT -1] = {
1072+
/*static*/ const char * const AudioPolicyService::kInputSourceNames[AUDIO_SOURCE_CNT -1] = {
10731073
MIC_SRC_TAG,
10741074
VOICE_UL_SRC_TAG,
10751075
VOICE_DL_SRC_TAG,

services/audioflinger/AudioPolicyService.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ class AudioPolicyService :
254254
Vector< sp<AudioEffect> >mEffects;
255255
};
256256

257-
static const char *kInputSourceNames[AUDIO_SOURCE_CNT -1];
257+
static const char * const kInputSourceNames[AUDIO_SOURCE_CNT -1];
258258

259259
void setPreProcessorEnabled(InputDesc *inputDesc, bool enabled);
260260
status_t loadPreProcessorConfig(const char *path);

0 commit comments

Comments
 (0)