Skip to content

Commit 0d7a997

Browse files
gkastenAndroid (Google) Code Review
authored andcommitted
Merge "For booleans, use ! instead of == false"
2 parents e119bd1 + b737dbb commit 0d7a997

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

services/audioflinger/AudioFlinger.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ static bool tryLock(Mutex& mutex)
331331

332332
status_t AudioFlinger::dump(int fd, const Vector<String16>& args)
333333
{
334-
if (checkCallingPermission(String16("android.permission.DUMP")) == false) {
334+
if (!checkCallingPermission(String16("android.permission.DUMP"))) {
335335
dumpPermissionDenial(fd, args);
336336
} else {
337337
// get state of hardware lock
@@ -1962,7 +1962,7 @@ bool AudioFlinger::MixerThread::threadLoop()
19621962
ALOGV("MixerThread %p TID %d waking up\n", this, gettid());
19631963
acquireWakeLock_l();
19641964

1965-
if (mMasterMute == false) {
1965+
if (!mMasterMute) {
19661966
char value[PROPERTY_VALUE_MAX];
19671967
property_get("ro.audio.silent", value, "0");
19681968
if (atoi(value)) {
@@ -2659,7 +2659,7 @@ bool AudioFlinger::DirectOutputThread::threadLoop()
26592659
ALOGV("DirectOutputThread %p TID %d waking up in active mode\n", this, gettid());
26602660
acquireWakeLock_l();
26612661

2662-
if (mMasterMute == false) {
2662+
if (!mMasterMute) {
26632663
char value[PROPERTY_VALUE_MAX];
26642664
property_get("ro.audio.silent", value, "0");
26652665
if (atoi(value)) {
@@ -3054,7 +3054,7 @@ bool AudioFlinger::DuplicatingThread::threadLoop()
30543054
ALOGV("DuplicatingThread %p TID %d waking up\n", this, gettid());
30553055
acquireWakeLock_l();
30563056

3057-
if (mMasterMute == false) {
3057+
if (!mMasterMute) {
30583058
char value[PROPERTY_VALUE_MAX];
30593059
property_get("ro.audio.silent", value, "0");
30603060
if (atoi(value)) {

services/audioflinger/AudioPolicyService.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ status_t AudioPolicyService::dumpInternals(int fd)
587587

588588
status_t AudioPolicyService::dump(int fd, const Vector<String16>& args)
589589
{
590-
if (checkCallingPermission(String16("android.permission.DUMP")) == false) {
590+
if (!checkCallingPermission(String16("android.permission.DUMP"))) {
591591
dumpPermissionDenial(fd);
592592
} else {
593593
bool locked = tryLock(mLock);

0 commit comments

Comments
 (0)