fix: prevent text loss in UITextEllipsisOverflow#36
Open
kangsangyeon wants to merge 1 commit intoHaruma-K:masterfrom
Open
fix: prevent text loss in UITextEllipsisOverflow#36kangsangyeon wants to merge 1 commit intoHaruma-K:masterfrom
kangsangyeon wants to merge 1 commit intoHaruma-K:masterfrom
Conversation
Author
|
Additionally, this PR can resolve existing issues that have been posted. #30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Maintainer,
I am submitting this PR to address a bug where the UITextEllipsisOverflow component permanently clears the text when it is initialized within dynamic layout systems (such as GridLayoutGroup).
Summary of Changes
How to Reproduce
In DefaultCellDemoDebugPage.cs, simply change line 210 from for (var i = 0; i < 9; i++) to for (var i = 0; i < 2; i++).
The Problem
The issue stems from a timing conflict between text assignment and layout initialization:
The Solution
I have updated the component to decouple the Original Text (Source of Truth) from the Display Output:
This change ensures that text remains visible and correctly truncated regardless of whether the ellipsis logic triggers before or after the layout engine provides the final dimensions.