Skip to content

fix: removed cert polling loop (handled on docker-compose lvl with de…#199

Merged
HardMax71 merged 1 commit intomainfrom
fix/deploy-params
Feb 16, 2026
Merged

fix: removed cert polling loop (handled on docker-compose lvl with de…#199
HardMax71 merged 1 commit intomainfrom
fix/deploy-params

Conversation

@HardMax71
Copy link
Owner

@HardMax71 HardMax71 commented Feb 16, 2026

…pends_on), passing web_xx params as env vars, config.toml - lowered web_concurrency


Summary by cubic

Removed the TLS cert polling loop and now rely on docker-compose depends_on for startup order. Made Gunicorn settings configurable via env vars and lowered default concurrency to reduce memory use.

  • Refactors
    • Removed cert wait loop in entrypoint; compose handles readiness via service_completed_successfully.
    • Wired WEB_CONCURRENCY, WEB_THREADS, and WEB_TIMEOUT env vars into Gunicorn; added defaults in docker-compose.
    • Reduced default WEB_CONCURRENCY from 4 to 2 in config.toml.

Written for commit 9c0f2b8. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Simplified backend startup process and improved Docker orchestration integration
    • Enhanced server configuration flexibility with environment variables for concurrency, thread count, and request timeout with optimized defaults

…pends_on), passing web_xx params as env vars, config.toml - lowered web_concurrency
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

📝 Walkthrough

Walkthrough

The changes reconfigure the backend service to use environment-variable-based settings for web server parameters (concurrency, threads, timeout) instead of hardcoded values. The Dockerfile entrypoint no longer waits for TLS certificate readiness, deferring this to docker-compose orchestration, while the configuration value for WEB_CONCURRENCY is reduced from 4 to 2.

Changes

Cohort / File(s) Summary
Web Server Configuration
backend/Dockerfile, backend/config.toml, docker-compose.yaml
Migrated to environment-variable-based configuration for web server parameters (WEB_CONCURRENCY, WEB_THREADS, WEB_TIMEOUT); removed TLS certificate wait loop from Dockerfile entrypoint; reduced WEB_CONCURRENCY default from 4 to 2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 No more waiting for certs in the night,
Environment variables dancing so bright,
Workers and threads now configurable with care,
The backend hops swiftly through docker-compose air! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the certificate polling loop, with the key detail about Docker Compose handling being the focus.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/deploy-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
backend/config.toml (1)

91-100: ⚠️ Potential issue | 🟡 Minor

These config values are consistent with docker-compose, but document the relationship to avoid confusion.

The WEB_CONCURRENCY, WEB_THREADS, and WEB_TIMEOUT values in config.toml (2, 4, and 60 respectively) currently match the environment variable defaults in docker-compose.yaml. However, they serve different purposes: in Docker, gunicorn uses the environment variables directly from the entrypoint script; if the application is run locally via main.py, it reads these values from config.toml through settings.py. The settings.py class defines different defaults (WEB_CONCURRENCY=4, WEB_THREADS=1), so removing these keys from config.toml without updating the code would silently cause the app to use incorrect values.

Consider adding a comment here clarifying that these values should be kept in sync with docker-compose.yaml defaults, or document why they differ if they intentionally should.

@HardMax71 HardMax71 merged commit b97e3a1 into main Feb 16, 2026
16 checks passed
@HardMax71 HardMax71 deleted the fix/deploy-params branch February 16, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments