fix: removed cert polling loop (handled on docker-compose lvl with de…#199
fix: removed cert polling loop (handled on docker-compose lvl with de…#199
Conversation
…pends_on), passing web_xx params as env vars, config.toml - lowered web_concurrency
📝 WalkthroughWalkthroughThe changes reconfigure the backend service to use environment-variable-based settings for web server parameters (concurrency, threads, timeout) instead of hardcoded values. The Dockerfile entrypoint no longer waits for TLS certificate readiness, deferring this to docker-compose orchestration, while the configuration value for WEB_CONCURRENCY is reduced from 4 to 2. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
backend/config.toml (1)
91-100:⚠️ Potential issue | 🟡 MinorThese config values are consistent with docker-compose, but document the relationship to avoid confusion.
The
WEB_CONCURRENCY,WEB_THREADS, andWEB_TIMEOUTvalues in config.toml (2, 4, and 60 respectively) currently match the environment variable defaults in docker-compose.yaml. However, they serve different purposes: in Docker, gunicorn uses the environment variables directly from the entrypoint script; if the application is run locally viamain.py, it reads these values from config.toml throughsettings.py. Thesettings.pyclass defines different defaults (WEB_CONCURRENCY=4, WEB_THREADS=1), so removing these keys from config.toml without updating the code would silently cause the app to use incorrect values.Consider adding a comment here clarifying that these values should be kept in sync with docker-compose.yaml defaults, or document why they differ if they intentionally should.



…pends_on), passing web_xx params as env vars, config.toml - lowered web_concurrency
Summary by cubic
Removed the TLS cert polling loop and now rely on docker-compose depends_on for startup order. Made Gunicorn settings configurable via env vars and lowered default concurrency to reduce memory use.
Written for commit 9c0f2b8. Summary will update on new commits.
Summary by CodeRabbit