fix: removed helm deploy - now through docker-compose/shell file, updated docs#140
fix: removed helm deploy - now through docker-compose/shell file, updated docs#140
Conversation
📝 WalkthroughWalkthroughThis PR eliminates Helm-based Kubernetes deployment infrastructure, removing all Helm chart templates and related configuration. Worker services consolidate to use a pre-built backend image with runtime command overrides. Docker Compose becomes the exclusive deployment mechanism, replacing the previous dual local/production workflow. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
deploy.sh (1)
105-108:⚠️ Potential issue | 🟡 Minor
--timeoutwithout a value will produce an empty--wait-timeoutflag.If
--timeoutis passed as the last argument (no value follows),WAIT_TIMEOUTis set to an empty string, which will causedocker compose up ... --wait-timeout ""to fail with a confusing error.Proposed fix: validate the shifted value
--timeout) shift + if [[ -z "$1" || "$1" == --* ]]; then + print_error "--timeout requires a value in seconds" + exit 1 + fi WAIT_TIMEOUT="$1" ;;Apply the same pattern to
cmd_infraat Line 166..github/workflows/docker.yml (1)
138-145:⚠️ Potential issue | 🟡 MinorSummary table is missing
cert-generatorandzookeeper-certgen.The summary claims "All 5 images scanned" but the pull-command table only lists 3 images (Base, Backend, Frontend). The two utility images that are scanned and promoted (Lines 112-113) are omitted from the summary.
Proposed fix: add the missing rows
echo "| Base | \`docker pull $REGISTRY/$PREFIX/base:latest\` |" >> $GITHUB_STEP_SUMMARY echo "| Backend | \`docker pull $REGISTRY/$PREFIX/backend:latest\` |" >> $GITHUB_STEP_SUMMARY echo "| Frontend | \`docker pull $REGISTRY/$PREFIX/frontend:latest\` |" >> $GITHUB_STEP_SUMMARY + echo "| Cert Generator | \`docker pull $REGISTRY/$PREFIX/cert-generator:latest\` |" >> $GITHUB_STEP_SUMMARY + echo "| Zookeeper Certgen | \`docker pull $REGISTRY/$PREFIX/zookeeper-certgen:latest\` |" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARYdocker-compose.yaml (1)
419-437:⚠️ Potential issue | 🟠 MajorAdd
mongodependency topod-monitorservice.
pod-monitorinitializes MongoDB connection and Beanie ORM at startup (AsyncMongoClientandinit_beanieare called in the main async function), but currently declares only akafka-initdependency. This will cause startup failures if MongoDB is not available. Addmongotodepends_onto match the pattern used by other workers that access the database (coordinator, k8s-worker, result-processor, saga-orchestrator, event-replay, dlq-processor).
🧹 Nitpick comments (2)
docs/components/dead-letter-queue.md (1)
39-39: Minor: phrasing reads slightly awkwardly after the rename.
run_dlq_processoris a script, not a service. Consider something like "The DLQ processor (run_dlq_processor.py) is a separate service that monitors…" for clarity.deploy.sh (1)
92-119: Unknown flags are silently ignored.The
caseblock has no*)default branch, so unrecognized flags (e.g.,./deploy.sh dev --typo) are consumed without warning. Consider adding a catch-all to alert the user.Proposed fix
--debug) PROFILE_FLAGS="--profile observability --profile debug" print_info "Including observability + debug tools (Kafdrop, etc.)" ;; + *) + print_error "Unknown option: $1" + show_help + exit 1 + ;; esac



Summary by cubic
Replaces Helm-based deployment with a single Docker Compose flow via deploy.sh. All workers now run from the backend image with command overrides, and docs/CI are updated to match.
Refactors
Migration
Written for commit c99f4e9. Summary will update on new commits.
Summary by CodeRabbit
Chores
Documentation
Refactor