refactor(frontend): dashboard logs inside virtual list#101
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the clusters dashboard widgets (notably logs) by introducing a custom virtualized list implementation and reorganizing cluster widgets into a dedicated widgets/ folder, alongside dependency updates.
Changes:
- Added a home-grown
VirtualListcomponent and refactored cluster logs to render through it (plus a new$lib/components/ClusterLogs.svelte). - Introduced a reusable
Widget.sveltewrapper and moved cluster logs/shards intocomponents/widgets/. - Updated frontend dependencies (Skeleton, Svelte, Tailwind, Vite, Oxlint) and refreshed the lockfile.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile updates reflecting dependency bumps. |
| packages/frontend/package.json | Bumps Svelte/Skeleton/Tailwind/Vite tooling versions. |
| packages/frontend/src/routes/(form)/setup/components/Account.svelte | Updates enhance callback usage to reset the form via element. |
| packages/frontend/src/routes/(form)/setup/components/Bot.svelte | Updates enhance callback usage to reset the form via element. |
| packages/frontend/src/routes/(app)/clusters/+page.svelte | Refactors collapsible rendering and switches to new widget components. |
| packages/frontend/src/routes/(app)/clusters/components/Widget.svelte | New shared widget wrapper component for cluster cards. |
| packages/frontend/src/routes/(app)/clusters/components/widgets/ClusterLogs.svelte | New logs widget wrapper using $lib/components/ClusterLogs.svelte. |
| packages/frontend/src/routes/(app)/clusters/components/widgets/ClusterShards.svelte | New shards widget wrapper using Widget.svelte. |
| packages/frontend/src/lib/remotes/clusters.remote.ts | Refactors getClusterLogs query signature and reverses returned log order. |
| packages/frontend/src/lib/components/VirtualList.svelte | New virtual list implementation used for log rendering. |
| packages/frontend/src/lib/components/ClusterLogs.svelte | New shared log viewer built on VirtualList with boundary/pending/failed snippets. |
| packages/frontend/src/routes/(app)/clusters/components/Header.svelte | Removed (functionality appears reorganized into other components). |
| packages/frontend/src/routes/(app)/clusters/components/ClusterLogs.svelte | Removed (superseded by new widget/lib component). |
| packages/frontend/src/routes/(app)/clusters/components/ClusterShards.svelte | Removed (superseded by new widget component). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Briefly describe what this PR does :
Display cluster logs inside a virtual list for better performance.
Context / Motivation
Explain why this change is needed:
Too many logs would make the dashboard crash
Checklist
Additional Notes