Skip to content

Conversation

@balajis-qb
Copy link
Contributor

@balajis-qb balajis-qb commented Jan 28, 2026

Description

Linked issue: #6223

Problem
As mentioned in the attached ticket, the month select dropdown (showMonthDropdown) and the year select drop down (showYearDropdown) lacks ARIA attributes.

Changes

  • Added the corresponding aria attributes to the select and the button element to support the dropdown mode (dropdownMode) of scroll and select
  • Added test cases to validate the change

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@balajis-qb balajis-qb force-pushed the issue-6223/fix/month-dropdown-accessibility branch from 5cbdd4d to 7f61d82 Compare January 28, 2026 16:58
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.29%. Comparing base (548a1f3) to head (7f61d82).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6232   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          30       30           
  Lines        3822     3824    +2     
  Branches     1648     1667   +19     
=======================================
+ Hits         3795     3797    +2     
  Misses         26       26           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant