feat: add time-aware EDM support and realistic animations (fixes #406)#822
feat: add time-aware EDM support and realistic animations (fixes #406)#822deveshbervar wants to merge 2 commits intoHSF:mainfrom
Conversation
deveshbervar
commented
Mar 12, 2026
- Add EventTime and EventMetadata interfaces to event-data-loader.ts
- Add optional getEventTime?() to EventDataLoader interface
- Extract event-level time (ns) in PhoenixLoader.buildEventData()
- Forward event time to AnimationsManager
- Add setEventTime(), getTimeProgress(), update() to AnimationsManager
- Add Event Time Progress slider to dat-gui UI
- Add tests for time extraction in phoenix-loader.test.ts
) - Add EventTime and EventMetadata interfaces to event-data-loader.ts - Add optional getEventTime?() to EventDataLoader interface - Extract event-level time (ns) in PhoenixLoader.buildEventData() - Forward event time to AnimationsManager - Add setEventTime(), getTimeProgress(), update() to AnimationsManager - Add Event Time Progress slider to dat-gui UI - Add tests for time extraction in phoenix-loader.test.ts
|
Hi @deveshbervar - sorry for taking so long to review this. I have to admit, I was a bit confused (and remain a bit confused) about that the intention is here. I don't really understand what |
|
Hi @EdwardMoyse, Thanks a lot for the review! What
|
|
Sorry, another long delay. So some quick comments, eventTime seems to be treated more as a The way this would work is if we had timing information added to e.g. hits. Then as the animation progressed, objects would grow and become visible. As it is right now, we assume that there is an expanding wave of particles coming from the origin in a sphere and hits appear as the sphere hits them. This assumption is completely wrong if the detector is not symmetric around an origin and if the particles do not come from the collision. An example from ATLAS would be for cosmic rays, where they come from top to bottom, and if we included hit level (or track level) timing information this could be visualised better. So as it stands, I'm not really sure that this PR is going in the right direction. And in particular, if (We also don't really use dat.gui any more) |
|
Hi @EdwardMoyse, Thank you for the detailed explanation — this is very helpful! I understand now:
Would you prefer I:
I'm happy to start with just the EDM change (adding optional |