fix: 下载页面标签显示未进行 shouldDisplayCategory 判断#5946
Merged
Glavo merged 1 commit intoHMCL-dev:mainfrom Apr 12, 2026
Merged
Conversation
Contributor
CiiLu
commented
Apr 12, 2026
CiiLu
commented
表现：Modrinth源所有资源包都有多余的 “Minecraft” 标签，且该标签在搜索页面也是不可见的
Glavo
approved these changes
Apr 12, 2026
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a filtering step in the DownloadPage class to ensure only relevant categories are displayed for an addon. The feedback suggests refactoring the stream operation by extracting the getSkinnable() call into a local variable and using method references to enhance code readability and efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.