Conversation
|
顺便看一下这个 HMCL-dev/HMCL-docs#435 (comment) |
|
/gemini review |
1 similar comment
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the release schedule documentation by refining the Mermaid gantt charts across the English, Simplified Chinese, and Traditional Chinese versions. The updates include enabling compact display mode, reordering version sections, and adding specific version milestones along with a current date marker. Feedback was provided to translate the 'today' label in the localized Chinese files to maintain language consistency.
There was a problem hiding this comment.
Code Review
This pull request updates the release schedule documentation across English, Simplified Chinese, and Traditional Chinese versions by adding detailed version milestones and status indicators to the Mermaid Gantt charts. However, the feedback indicates that reversing the section order (listing 3.11 before 3.10 and 3.9) breaks the chart's dependency logic because task IDs are referenced via the "after" keyword before they are defined. Additionally, the use of the non-standard keyword "vert" should be replaced with "milestone" to ensure valid Mermaid syntax.
https://github.com/HMCL-dev/HMCL/blob/20d112404e1c5db20db95e9f8b1b4ad5e73bde1f/docs/ReleaseSchedule.md
https://github.com/HMCL-dev/HMCL/blob/20d112404e1c5db20db95e9f8b1b4ad5e73bde1f/docs/ReleaseSchedule_zh.md
https://github.com/HMCL-dev/HMCL/blob/20d112404e1c5db20db95e9f8b1b4ad5e73bde1f/docs/ReleaseSchedule_zh_Hant.md