Skip to content

fix: 光影下载被错误地显示为 支持中英文搜索#5558

Merged
Glavo merged 2 commits intoHMCL-dev:mainfrom
CiiLu:www.bilibili.com/video/BV1VFZEBEEPo
Feb 20, 2026
Merged

fix: 光影下载被错误地显示为 支持中英文搜索#5558
Glavo merged 2 commits intoHMCL-dev:mainfrom
CiiLu:www.bilibili.com/video/BV1VFZEBEEPo

Conversation

@CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Feb 17, 2026

No description provided.

@CiiLu CiiLu force-pushed the www.bilibili.com/video/BV1VFZEBEEPo branch from 2a3dd88 to c8a3fc3 Compare February 17, 2026 15:28
@3gf8jv4dv
Copy link
Contributor

#5313 还有机会么

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the shader pack download list page so it is no longer displayed as supporting Chinese/English search (by disabling the supportChinese UI flag for shader packs).

Changes:

  • Update ofShaderPack(...) to construct the page instance, then disable supportChinese before returning it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 53 to 55
HMCLLocalizedDownloadListPage hmclLocalizedDownloadListPage = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
hmclLocalizedDownloadListPage.supportChinese.set(false);
return hmclLocalizedDownloadListPage;
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local variable name hmclLocalizedDownloadListPage is overly verbose and repeats the type name; a shorter name like page (consistent with other factory methods in this class) would improve readability while keeping the same behavior.

Suggested change
HMCLLocalizedDownloadListPage hmclLocalizedDownloadListPage = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
hmclLocalizedDownloadListPage.supportChinese.set(false);
return hmclLocalizedDownloadListPage;
HMCLLocalizedDownloadListPage page = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
page.supportChinese.set(false);
return page;

Copilot uses AI. Check for mistakes.
@Wulian233
Copy link
Contributor

请不要再使用这些特殊的分支名。提交 PR 前请确定你的分支名仅包含 [a-zA-Z0-9./-_] 这些字符,不要在分支名里搞怪。。

@Glavo Glavo merged commit 1e42034 into HMCL-dev:main Feb 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments