Skip to content

[Enhancement] 下载界面简介不滚动 #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Calboot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Enhancement] 下载界面简介不滚动 #5458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,17 +205,12 @@ protected ModDownloadPageSkin(DownloadPage control) {
VBox pane = new VBox(8);
pane.getStyleClass().add("gray-background");
pane.setPadding(new Insets(10));
ScrollPane scrollPane = new ScrollPane(pane);
FXUtils.smoothScrolling(scrollPane);
scrollPane.setFitToWidth(true);
scrollPane.setFitToHeight(true);

HBox descriptionPane = new HBox(8);
descriptionPane.setMinHeight(Region.USE_PREF_SIZE);
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the outer ScrollPane, the header/description area is no longer scrollable. Because content.getSubtitleLabel().setWrapText(true) and descriptionPane.setMinHeight(Region.USE_PREF_SIZE), a long mod description can grow the header to its full preferred height and leave the versions list with little/zero visible space, with no way to scroll to the list. Consider constraining the description area (e.g., cap its max height / clamp subtitle lines / remove the USE_PREF_SIZE min-height so it can shrink) so the versions list remains reachable at small window heights or with long descriptions.

Suggested change
descriptionPane.setMinHeight(Region.USE_PREF_SIZE);

Copilot uses AI. Check for mistakes.
descriptionPane.setAlignment(Pos.CENTER);
pane.getChildren().add(descriptionPane);
descriptionPane.getStyleClass().add("card-non-transparent");
BorderPane.setMargin(descriptionPane, new Insets(11, 11, 0, 11));
{
ImageView imageView = new ImageView();
imageView.setFitWidth(40);
Expand Down Expand Up @@ -266,8 +261,12 @@ protected ModDownloadPageSkin(DownloadPage control) {
spinnerPane.setOnFailedAction(e -> getSkinnable().loadModVersions());

ComponentList list = new ComponentList();
StackPane.setAlignment(list, Pos.TOP_CENTER);
spinnerPane.setContent(list);
ScrollPane scrollPane = new ScrollPane(list);
FXUtils.smoothScrolling(scrollPane);
scrollPane.setFitToWidth(true);
scrollPane.setFitToHeight(true);
StackPane.setAlignment(scrollPane, Pos.TOP_CENTER);
spinnerPane.setContent(scrollPane);

FXUtils.onChangeAndOperate(control.loaded, loaded -> {
if (control.versions == null) return;
Expand Down Expand Up @@ -321,7 +320,7 @@ protected ModDownloadPageSkin(DownloadPage control) {
});
}

getChildren().setAll(scrollPane);
getChildren().setAll(pane);
}
}

Expand Down
Loading