Skip to content

fix(25584): Set action column background#25590

Merged
linuspahl merged 2 commits intomasterfrom
fix/25584-PET-action-column-background
Apr 10, 2026
Merged

fix(25584): Set action column background#25590
linuspahl merged 2 commits intomasterfrom
fix/25584-PET-action-column-background

Conversation

@zeeklop
Copy link
Copy Markdown
Contributor

@zeeklop zeeklop commented Apr 9, 2026

Added back the background color to the Actions column

closes: #25584

/nocl

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@zeeklop zeeklop requested review from a team, Copilot and linuspahl April 9, 2026 14:34
@zeeklop zeeklop self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores a non-transparent background for the EntityDataTable “Actions” column so the pinned/sticky actions area doesn’t visually blend with underlying content.

Changes:

  • Default the actions column background to the theme’s global.contentBackground when no parentBgColor is provided.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -34,8 +34,8 @@ const AlignRight = styled.div`
`;

const BackgroundFoundation = styled.div<{ $parentBgColor: string }>(
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BackgroundFoundation declares $parentBgColor as a required string, but the component is passed parentBgColor: string | undefined and the style logic uses ?? to handle the undefined case. To keep the typing consistent with actual usage (and the fallback behavior), make $parentBgColor optional (or string | undefined) in the styled-component props type.

Suggested change
const BackgroundFoundation = styled.div<{ $parentBgColor: string }>(
const BackgroundFoundation = styled.div<{ $parentBgColor?: string }>(

Copilot uses AI. Check for mistakes.
@linuspahl linuspahl merged commit a8a92a0 into master Apr 10, 2026
24 of 25 checks passed
@linuspahl linuspahl deleted the fix/25584-PET-action-column-background branch April 10, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entity table: Background color of sticky actions column is transparent

3 participants