fix(25584): Set action column background#25590
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores a non-transparent background for the EntityDataTable “Actions” column so the pinned/sticky actions area doesn’t visually blend with underlying content.
Changes:
- Default the actions column background to the theme’s
global.contentBackgroundwhen noparentBgColoris provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -34,8 +34,8 @@ const AlignRight = styled.div` | |||
| `; | |||
|
|
|||
| const BackgroundFoundation = styled.div<{ $parentBgColor: string }>( | |||
There was a problem hiding this comment.
BackgroundFoundation declares $parentBgColor as a required string, but the component is passed parentBgColor: string | undefined and the style logic uses ?? to handle the undefined case. To keep the typing consistent with actual usage (and the fallback behavior), make $parentBgColor optional (or string | undefined) in the styled-component props type.
Suggested change
| const BackgroundFoundation = styled.div<{ $parentBgColor: string }>( | |
| const BackgroundFoundation = styled.div<{ $parentBgColor?: string }>( |
…/25584-PET-action-column-background
linuspahl
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added back the background color to the Actions column
closes: #25584
/nocl
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: