fix: change loadAsync return type to React.FC for call-signature bivariance#25064
Draft
dennisoelkers wants to merge 3 commits intomasterfrom
Draft
fix: change loadAsync return type to React.FC for call-signature bivariance#25064dennisoelkers wants to merge 3 commits intomasterfrom
dennisoelkers wants to merge 3 commits intomasterfrom
Conversation
…riance ComponentType<T> is invariant in T because its ComponentClass branch uses Readonly<T> in the constructor return type. This broke plugin binding assignments when components were lazy-loaded via loadAsync, since the inferred prop types no longer matched exactly. Returning React.FC<T> instead preserves TypeScript's call-signature bivariance, matching the behavior of direct component imports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that loadAsync-wrapped components are assignable to plugin binding slots using ComponentType<T>, including bivariant prop compatibility, ref-bearing props, and unknown prop inference. Also verify that completely incompatible prop types are still rejected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
ComponentType<T>is invariant inTbecause its ComponentClass branch usesReadonly<T>in the constructor return type. This broke plugin binding assignments when components were lazy-loaded via loadAsync, since the inferred prop types no longer matched exactly. ReturningReact.FC<T>instead preserves TypeScript's call-signature bivariance, matching the behavior of direct component imports.Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
/nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: