Conversation
linuspahl
changed the title
linuspahl
commented
Feb 24, 2026
| } | ||
|
|
||
| const newSearch = view.search.toBuilder().queries([newQuery]).build(); | ||
| const newSearch = await createSearch(view.search.toBuilder().newId().queries([newQuery]).build()); |
Contributor
Author
There was a problem hiding this comment.
This is reverting the change from https://github.com/Graylog2/graylog2-server/pull/24538/changes#r2614713831
dennisoelkers
approved these changes
Mar 3, 2026
Member
dennisoelkers
left a comment
dennisoelkers
left a comment
There was a problem hiding this comment.
Looks good, works well!
garybot2
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Apply URL overrides to saved searches. * Adding comment * Adding changelog * Extend unit tests (cherry picked from commit 5bc5da0)
garybot2
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Apply URL overrides to saved searches. * Adding comment * Adding changelog * Extend unit tests (cherry picked from commit 5bc5da0)
garybot2
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Apply URL overrides to saved searches. * Adding comment * Adding changelog * Extend unit tests (cherry picked from commit 5bc5da0)
linuspahl
added a commit
that referenced
this pull request
Mar 3, 2026
linuspahl
added a commit
that referenced
this pull request
Mar 3, 2026
linuspahl
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note, this PR needs to be backported.
Description
This bugfix ensures that opening a saved search with URL overrides (for example
?q=new-query) executes with the overridden values and keeps the override as transient UI state until the user explicitly saves.Problem
When opening a saved search URL with overrides, the UI could reflect the override while initial execution still ran with the saved search query.
Root Cause
Applying URL overrides without creating a new search in the backend could still execute against the original saved-search context.
What Changed
URL-bound query updates now create a new search which takes the URL query params into account.
Behavior After Fix
How has this been tested?
I tested different scenarios how to load a search and checked the network requests, search bar values and search results. I also added unit and e2e tests for this bugfix.
Fixes #25028
/prd https://github.com/Graylog2/e2e-tests/pull/1510