Skip to content

Update vite to version 8#3900

Open
TrueDoctor wants to merge 1 commit intomasterfrom
update-vite
Open

Update vite to version 8#3900
TrueDoctor wants to merge 1 commit intomasterfrom
update-vite

Conversation

@TrueDoctor
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the frontend build system by updating Vite to its major version 8.0.0. This upgrade involves a substantial shift in underlying tooling, including the adoption of Rolldown as the new JavaScript bundler and the integration of LightningCSS for efficient CSS processing. These changes aim to leverage the latest performance improvements and features offered by the updated ecosystem.

Highlights

  • Vite Upgrade: Upgraded the core frontend build tool, Vite, to its major version 8.0.0, bringing significant updates and performance enhancements.
  • Svelte Plugin Update: Updated the @sveltejs/vite-plugin-svelte to version 7.0.0 to ensure compatibility and leverage new features with Vite 8.
  • Bundler Transition to Rolldown: Integrated Rolldown as the new JavaScript bundler, replacing previous bundling solutions and modifying Vite's internal dependency structure for potentially faster builds.
  • CSS Processing with LightningCSS: Adopted LightningCSS for efficient CSS processing, indicating a shift in how stylesheets are handled within the build pipeline.
  • Dependency Management Refinement: Streamlined dependency management by removing the 'peer: true' property from numerous entries in package-lock.json, simplifying dependency resolution.
Changelog
  • frontend/package-lock.json
    • Updated @sveltejs/vite-plugin-svelte from 6.2.4 to 7.0.0.
    • Updated vite from 7.3.1 to 8.0.0.
    • Removed numerous @esbuild platform-specific optional dependencies.
    • Removed peer: true property from several dependency entries including @eslint/compat, @eslint/eslintrc, @eslint/js, deep-is, escalade, fast-levenshtein, find-up, flat-cache, flatted, globby, is-plain-obj, json-buffer, json-stable-stringify-without-jsonify, json-stringify-safe, lodash.merge, minimatch, postcss, prettier, rollup, source-map, ts-node, typescript, vitefu, and which.
    • Added new dependencies: @oxc-project/runtime, @oxc-project/types, lightningcss and its platform-specific optional dependencies, rolldown and its platform-specific optional binding dependencies, and @rolldown/pluginutils.
    • Updated postcss from 8.5.6 to 8.5.8.
    • Updated vitefu from 1.1.1 to 1.1.2.
    • Modified vite's internal dependencies to remove esbuild and fdir, and add @oxc-project/runtime, lightningcss, and rolldown.
    • Updated vite's peer dependencies to include @vitejs/devtools and esbuild, and removed lightningcss.
    • Updated @sveltejs/vite-plugin-svelte's dependencies and peer dependencies.
  • frontend/package.json
    • Updated @sveltejs/vite-plugin-svelte from ^6.2.4 to ^7.0.0.
    • Updated vite from ^7.3.1 to ^8.0.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Vite to a new major version (v8), which appears to be a pre-release version that replaces Rollup with Rolldown. This is a substantial architectural change that likely comes with breaking changes that could affect configuration files like vite.config.ts.

However, the pull request description is empty and still contains the template text. As per the contribution guidelines in the template, it should be filled out with details about the change. For a dependency upgrade of this magnitude, it's crucial to explain the motivation, the testing that has been performed, and any required changes to the development environment or build process.

Most importantly, the new package versions do not seem to be available on the public npm registry, which is a critical issue I've commented on separately.

"typescript": "^5.9.3",
"typescript-eslint": "^8.53.1",
"vite": "^7.3.1",
"vite": "^8.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The dependencies being updated to, including vite@8.0.0, @sveltejs/vite-plugin-svelte@7.0.0, and several others in package-lock.json, are not available on the public npm registry (registry.npmjs.org). This will cause npm install to fail for anyone who does not have access to a private registry or a pre-populated cache where these packages might exist. This is a critical issue for project reproducibility and developer onboarding. Please either use publicly available packages or provide clear instructions on how to configure the environment to resolve these dependencies.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="frontend/package.json">

<violation number="1" location="frontend/package.json:61">
P1: Vite 8 narrows the production browser target below this package's declared browserslist unless you set `build.target` explicitly.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

"typescript": "^5.9.3",
"typescript-eslint": "^8.53.1",
"vite": "^7.3.1",
"vite": "^8.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Vite 8 narrows the production browser target below this package's declared browserslist unless you set build.target explicitly.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At frontend/package.json, line 61:

<comment>Vite 8 narrows the production browser target below this package's declared browserslist unless you set `build.target` explicitly.</comment>

<file context>
@@ -58,7 +58,7 @@
 		"typescript": "^5.9.3",
 		"typescript-eslint": "^8.53.1",
-		"vite": "^7.3.1",
+		"vite": "^8.0.0",
 		"vite-multiple-assets": "2.2.6"
 	},
</file context>

@github-actions github-actions bot requested a deployment to graphite-dev (Preview) March 14, 2026 08:22 Abandoned
@Keavon Keavon force-pushed the master branch 3 times, most recently from e58c1de to df8001f Compare March 17, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant