Skip to content

Fix several warnings from GCC 16#396

Open
gruenich wants to merge 4 commits intoGraphBLAS:v1.3.xfrom
gruenich:feature/fix-gcc-16-warnings
Open

Fix several warnings from GCC 16#396
gruenich wants to merge 4 commits intoGraphBLAS:v1.3.xfrom
gruenich:feature/fix-gcc-16-warnings

Conversation

@gruenich
Copy link
Copy Markdown

No description provided.

LG_TRY (LAGraph_Finalize (msg)) ;
return (GrB_SUCCESS) ;
}

No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete this line. I use these to navigate with vim. If gcc 16 is complaining about it, then it would complain in 100s of places in my codes, and the warning should just be silenced instead.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last line had some trailing white space. I removed it, now it is similar to all the other files. Difficult to tell by the web diff.

@DrTimothyAldenDavis
Copy link
Copy Markdown
Member

These changes are being made to the stable branch, but the stable branch is out of date with the latest development branch ( https://github.com/GraphBLAS/LAGraph/tree/v1.3.x ).

Found by GCC 16 (-Wpedantic).
@gruenich gruenich force-pushed the feature/fix-gcc-16-warnings branch from 1e482a7 to 97e4a03 Compare March 26, 2026 10:09
@gruenich gruenich changed the base branch from stable to v1.3.x March 26, 2026 10:24
Found by GCC 16 (-Wenum-int-mismatch).
Found by GCC 16 (-Wunused-variable).
Match with declaration in header.
Found by GCC 16 (-Warray-paramter).
@gruenich gruenich force-pushed the feature/fix-gcc-16-warnings branch from 97e4a03 to 3e21558 Compare March 27, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants