Skip to content

Make most transformers pattern-filterable#2028

Merged
Goooler merged 1 commit into
mainfrom
g/20250515/use-more-pattern-transformer
May 15, 2026
Merged

Make most transformers pattern-filterable#2028
Goooler merged 1 commit into
mainfrom
g/20250515/use-more-pattern-transformer

Conversation

@Goooler
Copy link
Copy Markdown
Member

@Goooler Goooler commented May 15, 2026

Refs #1849.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler changed the title Make most transformers extends PatternFilterableResourceTransformer Make most transformers pattern-filterable May 15, 2026
@Goooler Goooler requested a review from Copilot May 15, 2026 10:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes several built-in resource transformers extend PatternFilterableResourceTransformer, allowing their patternSet to be publicly configured while preserving their default matching behavior.

Changes:

  • Converts manifest, Log4j2 plugin cache, Groovy extension module, and Plexus components transformers to pattern-filterable implementations.
  • Adds public constructors accepting PatternSet where applicable and updates the API snapshot.
  • Documents the newly exposed patternSet APIs in the Unreleased changelog.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestResourceTransformer.kt Makes manifest transformation pattern-filterable with case-insensitive default manifest matching.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformer.kt Makes manifest appending pattern-filterable with case-insensitive default manifest matching.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/Log4j2PluginsCacheFileTransformer.kt Makes Log4j2 plugin cache transformation pattern-filterable.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/GroovyExtensionModuleTransformer.kt Makes Groovy extension module transformation pattern-filterable.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ComponentsXmlResourceTransformer.kt Makes Plexus components XML transformation pattern-filterable.
docs/changes/README.md Adds Unreleased changelog entries for the newly exposed pattern sets.
api/shadow.api Updates the public API baseline for the new inheritance and constructors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Goooler Goooler merged commit 4a7db87 into main May 15, 2026
12 checks passed
@Goooler Goooler deleted the g/20250515/use-more-pattern-transformer branch May 15, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants