Make most transformers pattern-filterable#2028
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes several built-in resource transformers extend PatternFilterableResourceTransformer, allowing their patternSet to be publicly configured while preserving their default matching behavior.
Changes:
- Converts manifest, Log4j2 plugin cache, Groovy extension module, and Plexus components transformers to pattern-filterable implementations.
- Adds public constructors accepting
PatternSetwhere applicable and updates the API snapshot. - Documents the newly exposed
patternSetAPIs in the Unreleased changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestResourceTransformer.kt |
Makes manifest transformation pattern-filterable with case-insensitive default manifest matching. |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformer.kt |
Makes manifest appending pattern-filterable with case-insensitive default manifest matching. |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/Log4j2PluginsCacheFileTransformer.kt |
Makes Log4j2 plugin cache transformation pattern-filterable. |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/GroovyExtensionModuleTransformer.kt |
Makes Groovy extension module transformation pattern-filterable. |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ComponentsXmlResourceTransformer.kt |
Makes Plexus components XML transformation pattern-filterable. |
docs/changes/README.md |
Adds Unreleased changelog entries for the newly exposed pattern sets. |
api/shadow.api |
Updates the public API baseline for the new inheritance and constructors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1849.