Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Oct 10, 2025

No description provided.

@Goooler Goooler changed the title Tweak tests Tweak Spock tests Oct 10, 2025
@Goooler Goooler requested a review from Copilot October 10, 2025 07:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Spock test specifications to standardize test execution methods and improve test infrastructure. The changes primarily replace inconsistent test runner method calls with standardized naming and enhance the base test configuration.

  • Replaced run() and runWithDebug() calls with standardized runWithSuccess() method calls across all test files
  • Removed large, resource-intensive, and ignored test cases to streamline the test suite
  • Enhanced the base PluginSpecification class with improved Gradle runner configuration and additional deprecation warning detection

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PluginSpecification.groovy Enhanced base test class with standardized runner methods, TestKit configuration, and improved deprecation warning detection
AbstractCachingSpec.groovy Updated test method calls to use standardized runWithSuccess()
TransformerSpec.groovy Standardized all test execution calls to use runWithSuccess()
ShadowPluginSpec.groovy Removed large test cases and standardized test execution methods
RelocationSpec.groovy Updated test method calls to use standardized runWithSuccess()
PublishingSpec.groovy Standardized test execution calls to use runWithSuccess()
PropertiesFileTransformerSpec.groovy Updated test method calls to use standardized runWithSuccess()
FilteringSpec.groovy Standardized all test execution calls to use runWithSuccess()
ConfigureShadowRelocationSpec.groovy Updated test method calls to use standardized runWithSuccess()
ConfigurationCacheSpec.groovy Standardized test execution calls to use runWithSuccess()
ApplicationSpec.groovy Updated test method calls to use standardized runWithSuccess()

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Goooler Goooler marked this pull request as ready for review October 10, 2025 07:41
@Goooler Goooler enabled auto-merge (squash) October 10, 2025 07:42
@Goooler Goooler merged commit 1e5f74d into 8.x Oct 10, 2025
7 checks passed
@Goooler Goooler deleted the g/20251010/tweak-tests branch October 10, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants