Reporting info and debug logs other than Errors#88
Reporting info and debug logs other than Errors#88indrajeet0510 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
Adding custom resourceType and severity
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
| this.serviceContext = {service: config.service || 'web'}; | ||
| this.serviceContext = {service: config.service || 'web', | ||
| resourceType: config.resourceType || 'reported_errors', | ||
| severity: 'ERROR' || config.severity |
There was a problem hiding this comment.
Can you talk more about why you think severity should be stored in the config?
I would expect instead the severity to be provided every time an error is reported.
| this.context = config.context || {}; | ||
| this.serviceContext = {service: config.service || 'web'}; | ||
| this.serviceContext = {service: config.service || 'web', | ||
| resourceType: config.resourceType || 'reported_errors', |
There was a problem hiding this comment.
You are also adding resourceType in context.
I am supportive, but I recommend sending a different PR for this.
|
@steren I don't see anything on the Cloud Reporting API documentation about the |
Adding custom resourceType and severity