-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: removing snippet-gen samples from handwritten directory #13767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @iennae, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the sample code repository by removing specific auto-generated code snippets and their associated files. The primary goal is to ensure that generated samples are not mistakenly placed in directories meant for manually written code, thereby enhancing the overall structure and logical organization of the codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes several files related to an older, generated language_sentiment_text sample from the language/snippets/generated-samples/v1/ directory. The deleted files include the sample code, its test, and requirement files. This appears to be a cleanup of obsolete samples, as a more up-to-date version of the language_sentiment_text sample exists in language/v1/. The changes are straightforward and look correct.
Description
checking impact of removing generated samples out of handwritten samples. generally snippet-gen generated samples should never be in handwritten repos.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)