-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(secretmanager): Adding python cmek samples #13749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(secretmanager): Adding python cmek samples #13749
Conversation
…python-docs-samples into python_expiretime_samples
…python-docs-samples into python_expiretime_samples
…python-docs-samples into python_expiretime_samples
…-crest/python-docs-samples into python_rotation_samples
Summary of ChangesHello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Python samples for Google Cloud Secret Manager by introducing new functionalities for enhanced secret lifecycle management. It provides practical examples for configuring secrets with Customer-Managed Encryption Keys (CMEK), setting expiration dates, and establishing rotation schedules. Furthermore, the PR includes samples for interacting with secret tag bindings, allowing users to list and detach tags. These new samples cover both globally replicated and regionally managed secrets, ensuring comprehensive coverage for various deployment scenarios and improving the overall utility of the sample library. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive set of new Python samples for Google Cloud Secret Manager, covering features like CMEK, expiration, rotation, and tagging for both global and regional secrets. The changes are well-structured and the new samples are a valuable addition. I've identified a few areas for improvement, mainly around consistency in client usage, resource path construction, and a couple of bugs in the test assertions. Addressing these points will enhance the robustness and maintainability of the new samples.
secretmanager/snippets/regional_samples/delete_regional_secret_rotation.py
Show resolved
Hide resolved
secretmanager/snippets/regional_samples/create_regional_secret_with_cmek.py
Outdated
Show resolved
Hide resolved
secretmanager/snippets/regional_samples/create_regional_secret_with_expire_time.py
Outdated
Show resolved
Hide resolved
secretmanager/snippets/regional_samples/update_regional_secret_expiration.py
Show resolved
Hide resolved
…python-docs-samples into python_expiretime_samples
…-crest/python-docs-samples into python_rotation_samples
…rest/python-docs-samples into python_cmek_samples
…python-docs-samples into python_expiretime_samples
…-crest/python-docs-samples into python_rotation_samples
…rest/python-docs-samples into python_cmek_samples
…python-docs-samples into python_expiretime_samples
…-crest/python-docs-samples into python_rotation_samples
…rest/python-docs-samples into python_cmek_samples
Adding python cmek samples
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)