Skip to content

Conversation

@khilan-crest
Copy link

Adding python cmek samples

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Python samples for Google Cloud Secret Manager by introducing new functionalities for enhanced secret lifecycle management. It provides practical examples for configuring secrets with Customer-Managed Encryption Keys (CMEK), setting expiration dates, and establishing rotation schedules. Furthermore, the PR includes samples for interacting with secret tag bindings, allowing users to list and detach tags. These new samples cover both globally replicated and regionally managed secrets, ensuring comprehensive coverage for various deployment scenarios and improving the overall utility of the sample library.

Highlights

  • New Secret Management Samples: Added Python samples for creating and managing secrets with advanced features like Customer-Managed Encryption Keys (CMEK), expiration times, and rotation policies.
  • Tag Binding Operations: Introduced samples for listing and detaching tag bindings from secrets.
  • Regional Secret Support: Extended advanced secret management capabilities to regional secrets, including CMEK, expiration, rotation, and tag binding operations.
  • Comprehensive Update/Delete Samples: Provided corresponding samples for updating expiration and rotation settings, and deleting these configurations for both global and regional secrets.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive set of new Python samples for Google Cloud Secret Manager, covering features like CMEK, expiration, rotation, and tagging for both global and regional secrets. The changes are well-structured and the new samples are a valuable addition. I've identified a few areas for improvement, mainly around consistency in client usage, resource path construction, and a couple of bugs in the test assertions. Addressing these points will enhance the robustness and maintainability of the new samples.

@khilan-crest khilan-crest marked this pull request as ready for review January 30, 2026 05:25
@khilan-crest khilan-crest requested review from a team as code owners January 30, 2026 05:25
@snippet-bot
Copy link

snippet-bot bot commented Jan 30, 2026

Here is the summary of changes.

You are about to add 21 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant