Skip to content

Respect monitoring export timeouts#525

Open
Haihan-Jiang wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Haihan-Jiang:codex/monitoring-export-timeout
Open

Respect monitoring export timeouts#525
Haihan-Jiang wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Haihan-Jiang:codex/monitoring-export-timeout

Conversation

@Haihan-Jiang
Copy link
Copy Markdown

Summary

  • pass timeout_millis through to Cloud Monitoring descriptor creation and time series writes
  • convert from OpenTelemetry milliseconds to google client seconds
  • add coverage that export forwards timeout to both API calls

Fixes #215.

Testing

  • /tmp/otel-monitoring-venv/bin/python -m pytest opentelemetry-exporter-gcp-monitoring/tests/test_cloud_monitoring.py::test_export_passes_timeout_to_cloud_monitoring_client -q
  • /tmp/otel-monitoring-venv/bin/python -m pytest opentelemetry-exporter-gcp-monitoring/tests/test_cloud_monitoring.py -q
  • /tmp/otelpy-venv/bin/tox -e py312-ci-test-cloudmonitoring -- tests/test_cloud_monitoring.py -q
  • /tmp/otel-monitoring-venv/bin/black opentelemetry-exporter-gcp-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py opentelemetry-exporter-gcp-monitoring/tests/test_cloud_monitoring.py --check --diff
  • /tmp/otel-monitoring-venv/bin/isort opentelemetry-exporter-gcp-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py opentelemetry-exporter-gcp-monitoring/tests/test_cloud_monitoring.py --check-only --diff
  • git diff --check

@Haihan-Jiang Haihan-Jiang requested a review from a team as a code owner May 30, 2026 13:12
@Haihan-Jiang
Copy link
Copy Markdown
Author

This is ready for review from my side. The remaining ops-python-e2e Cloud Build checks appear to require project-side approval/run permissions; could someone take a look or trigger them when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect timeouts in metric exporter

1 participant