chore(deps): update multer to ^2.1.1 in appengine storage samples#4314
Open
angelcaamal wants to merge 1 commit into
Open
chore(deps): update multer to ^2.1.1 in appengine storage samples#4314angelcaamal wants to merge 1 commit into
angelcaamal wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request attempts to update the multer dependency version across several package.json files. However, the specified version ^2.1.1 does not exist on the npm registry, which will cause installation failures. It is recommended to revert to the stable ^1.4.5-lts.1 version, as 2.x versions are currently in pre-release and involve breaking changes.
Contributor
Author
|
The CI is failing in the before all hook with an IAM error: The member bindings allUsers and allAuthenticatedUsers are not allowed since public access prevention is enforced. This is related to a GCP project policy restriction (Public Access Prevention) affecting the test setup, and it is unrelated to the multer version bump in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Internal: b/512910668
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.