Skip to content

Add migration center assets export job resource and tests#17575

Merged
slevenick merged 2 commits into
GoogleCloudPlatform:mainfrom
slevenick:migration-center-assets-export-job
May 19, 2026
Merged

Add migration center assets export job resource and tests#17575
slevenick merged 2 commits into
GoogleCloudPlatform:mainfrom
slevenick:migration-center-assets-export-job

Conversation

@slevenick
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_migration_center_assets_export_job`

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4253722:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2193 insertions(+)
google-beta provider View Diff 5 files changed, 2193 insertions(+)
terraform-google-conversion View Diff 1 file changed, 238 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 115 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_migration_center_assets_export_job (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_migration_center_assets_export_job" "primary" {
  condition {
    filter = # value needed
  }
  recent_executions {
    result {
      error {
        code    = # value needed
        message = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 0 1
Affected Service Packages
  • migrationcenter

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMigrationCenterAssetsExportJob_migrationCenterAssetsExportJobBasicExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccMigrationCenterAssetsExportJob_migrationCenterAssetsExportJobBasicExample

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 4253722!

@slevenick slevenick requested review from a team and roaks3 and removed request for a team May 15, 2026 18:15
Copy link
Copy Markdown
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a non-blocking nit, but my understanding on the inheritance could be wrong or outdated. Otherwise LGTM.

Comment thread mmv1/products/migrationcenter/AssetsExportJob.yaml
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 19, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ee4438:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 2185 insertions(+)
google-beta provider View Diff 5 files changed, 2185 insertions(+)
terraform-google-conversion View Diff 1 file changed, 238 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 115 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_migration_center_assets_export_job (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_migration_center_assets_export_job" "primary" {
  condition {
    filter = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
8 8 0 0
Affected Service Packages
  • migrationcenter

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for 2ee4438!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants