Skip to content

New resource: Dialogflow SIP trunks#17569

Open
drebes wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
drebes:sip-trunks
Open

New resource: Dialogflow SIP trunks#17569
drebes wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
drebes:sip-trunks

Conversation

@drebes
Copy link
Copy Markdown
Contributor

@drebes drebes commented May 15, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_dialogflow_sip_trunk`

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6710cb4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1200 insertions(+)
google-beta provider View Diff 5 files changed, 1200 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 108 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_sip_trunk (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_sip_trunk" "primary" {
  connections {
    connection_id = # value needed
    error_details {
      code    = # value needed
      message = # value needed
    }
    state       = # value needed
    update_time = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_sip_trunk

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
21 19 0 2
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample
  • TestAccDialogflowSipTrunk_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDialogflowSipTrunk_update
❌ Error · Log - TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@drebes, @malhotrasagar2212 VCR tests complete for 6710cb4!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e91c69b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1152 insertions(+)
google-beta provider View Diff 5 files changed, 1152 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 108 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_sip_trunk (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_sip_trunk" "primary" {
  connections {
    connection_id = # value needed
    error_details {
      code    = # value needed
      message = # value needed
    }
    state       = # value needed
    update_time = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_sip_trunk

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
21 20 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@drebes, @malhotrasagar2212 VCR tests complete for e91c69b!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3cd7e62:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1164 insertions(+)
google-beta provider View Diff 5 files changed, 1164 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 108 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_sip_trunk (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_sip_trunk" "primary" {
  connections {
    connection_id = # value needed
    error_details {
      code    = # value needed
      message = # value needed
    }
    state       = # value needed
    update_time = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_sip_trunk

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
21 20 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@drebes, @malhotrasagar2212 VCR tests complete for 3cd7e62!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f78cb87:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1164 insertions(+)
google-beta provider View Diff 5 files changed, 1164 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 108 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_sip_trunk (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_sip_trunk" "primary" {
  connections {
    connection_id = # value needed
    error_details {
      code    = # value needed
      message = # value needed
    }
    state       = # value needed
    update_time = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_sip_trunk

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
21 20 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@drebes, @malhotrasagar2212 VCR tests complete for f78cb87!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 18, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c139e74:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1165 insertions(+)
google-beta provider View Diff 5 files changed, 1165 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 108 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_sip_trunk (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_sip_trunk" "primary" {
  connections {
    connection_id = # value needed
    error_details {
      code    = # value needed
      message = # value needed
    }
    state       = # value needed
    update_time = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_sip_trunk

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
21 20 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drebes, @malhotrasagar2212 VCR tests complete for c139e74!

Use self_link_as_name_set_project_and_location template for custom import to allow importing with full URI.

TAG=agy
CONV=623055e5-6e1b-4e3b-9659-6c104c64b438
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 18, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d7177ab:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1185 insertions(+)
google-beta provider View Diff 5 files changed, 1185 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 108 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_sip_trunk (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_sip_trunk" "primary" {
  connections {
    connection_id = # value needed
    error_details {
      code    = # value needed
      message = # value needed
    }
    state       = # value needed
    update_time = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_sip_trunk

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
21 20 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDialogflowSipTrunk_dialogflowSipTrunkBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@drebes, @malhotrasagar2212 VCR tests complete for d7177ab!

@drebes
Copy link
Copy Markdown
Contributor Author

drebes commented May 18, 2026

If only terraform-provider-missing-service-labels are blocking, this is already being addressed internally. Can you review the changes, @malhotrasagar2212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants